Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] go.mod: Bump hcsshim to v0.9.5 #7610

Merged

Conversation

katiewasnothere
Copy link
Contributor

This bumps hcsshim to include a bug fix from microsoft/hcsshim@cae120b.

You can see the full changelog here: https://github.com/microsoft/hcsshim/releases/tag/v0.9.5

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@k8s-ci-robot
Copy link

Hi @katiewasnothere. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevpar
Copy link
Member

kevpar commented Oct 31, 2022

/ok-to-test

@kevpar
Copy link
Member

kevpar commented Oct 31, 2022

Looks you might need to fix vendoring in /integration/client

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@jterry75
Copy link
Contributor

jterry75 commented Nov 1, 2022

LGTM. But just quick question. The change fix doesnt actually make it into containerd because the shim itself is a binary. Do we really need to take this? Or is that we use the go.mod version to determine which binary to build and thus we do need the update even the containerd vendor itself doesnt have any real code changes to speak of?

@katiewasnothere
Copy link
Contributor Author

LGTM. But just quick question. The change fix doesnt actually make it into containerd because the shim itself is a binary. Do we really need to take this? Or is that we use the go.mod version to determine which binary to build and thus we do need the update even the containerd vendor itself doesnt have any real code changes to speak of?

We use the go.mod version when building the binary 🙂

@katiewasnothere
Copy link
Contributor Author

Test failure looks unrelated afaict

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75
Copy link
Contributor

jterry75 commented Nov 1, 2022

@katiewasnothere 👍

Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar kevpar merged commit a865cb5 into containerd:release/1.6 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants