New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.6] go.mod: Bump hcsshim to v0.9.5 #7610
[release/1.6] go.mod: Bump hcsshim to v0.9.5 #7610
Conversation
Hi @katiewasnothere. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Looks you might need to fix vendoring in |
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
aebcc80
to
df73aca
Compare
LGTM. But just quick question. The change fix doesnt actually make it into containerd because the shim itself is a binary. Do we really need to take this? Or is that we use the go.mod version to determine which binary to build and thus we do need the update even the containerd vendor itself doesnt have any real code changes to speak of? |
We use the go.mod version when building the binary 🙂 |
Test failure looks unrelated afaict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This bumps hcsshim to include a bug fix from microsoft/hcsshim@cae120b.
You can see the full changelog here: https://github.com/microsoft/hcsshim/releases/tag/v0.9.5
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com