Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.19 #7500

Closed
lengrongfu opened this issue Oct 9, 2022 · 3 comments
Closed

Upgrade to Go 1.19 #7500

lengrongfu opened this issue Oct 9, 2022 · 3 comments

Comments

@lengrongfu
Copy link
Contributor

What is the problem you're trying to solve

The current Go1.19 version has been released for a while, do you want to upgrade to the Go1.19 version?

I read the PR for upgrading from 1.17 to 1.18 with different opinions, so upgrading to 1.19 needs to be discussed.

Go Doc has changed in 1.19. From the PR of kubernetes version 1.18 to 1.19, it can be seen that GoDoc has changed a lot.

Describe the solution you'd like

Additional context

No response

@fuweid
Copy link
Member

fuweid commented Oct 10, 2022

#7254 😅 closing

@fuweid fuweid closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2022
@lengrongfu
Copy link
Contributor Author

lengrongfu commented Oct 10, 2022

@fuweid Hi, this PR #7254 only changes the Go version in CI, the current Go version in go.mod is still 1.18

go 1.18

@fuweid
Copy link
Member

fuweid commented Oct 10, 2022

If I understand correctly, the go version in go.mod is minimum go version. Go 1.18 is still active, so the user can use go1.18 to build containerd. We can update it to go1.19 when go1.18 is EOF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants