Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] release workflow: increase timeout to 30 minutes & remove Go setup action #7261

Merged
merged 2 commits into from Aug 6, 2022

Conversation

samuelkarp
Copy link
Member

Backport of #7259

See run at https://github.com/samuelkarp/containerd/actions/runs/2807107122


In the 1.6.7 release, we saw significantly longer execution time for
producing builds that exceeded the previous timeout of 10 minutes,
causing the workflow to fail. After increasing to 20 minutes in the
release/1.6 branch, we continued to see one failure (which succeeded on
retry).

Increase to 30 minutes to provide additional buffer for the build to
complete.

Signed-off-by: Samuel Karp samuelkarp@google.com
(cherry picked from commit f8add92)
Signed-off-by: Samuel Karp samuelkarp@google.com

In the 1.6.7 release, we saw significantly longer execution time for
producing builds that exceeded the previous timeout of 10 minutes,
causing the workflow to fail.  After increasing to 20 minutes in the
release/1.6 branch, we continued to see one failure (which succeeded on
retry).

Increase to 30 minutes to provide additional buffer for the build to
complete.

Signed-off-by: Samuel Karp <samuelkarp@google.com>
(cherry picked from commit f8add92)
Signed-off-by: Samuel Karp <samuelkarp@google.com>
Release builds are performed from within a Dockerfile-defined
environment and do not require Go to be installed in the GitHub Actions
runner environment.

Signed-off-by: Samuel Karp <samuelkarp@google.com>
(cherry picked from commit 6ba91de)
Signed-off-by: Samuel Karp <samuelkarp@google.com>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a76f3c8 into containerd:release/1.6 Aug 6, 2022
@samuelkarp samuelkarp deleted the release-workflow/1.6 branch August 6, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants