Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare releases notes for 1.6.7 #7225

Merged
merged 2 commits into from Aug 4, 2022

Conversation

dcantah
Copy link
Member

@dcantah dcantah commented Jul 28, 2022

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dcantah
Copy link
Member Author

dcantah commented Jul 29, 2022

Oh there's another Windows related change that'd be nice to get into 1.6 also #7023

releases/v1.6.7.toml Outdated Show resolved Hide resolved
@dcantah dcantah force-pushed the v1.6.7-rnotes branch 3 times, most recently from 972ef3b to 4391d69 Compare July 29, 2022 19:32
@AkihiroSuda
Copy link
Member

Is this still draft?

@dcantah
Copy link
Member Author

dcantah commented Jul 31, 2022

@AkihiroSuda Ideally I'd like to get in #7023 and backported, had almost forgot about it. It's kind of walking the line between "backportable" however. Some folks want it fixed, but I'm not sure if anyone actually relied on the behavior today that's altered in that change, so maybe it makes sense to just land in 1.7. I'd argue what happens today is a bug however

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcantah
Copy link
Member Author

dcantah commented Aug 2, 2022

Sorry for the hold up here 😐 Like I mentioned I realized it'd be nice to get in another fix we had for Windows as it was fairly far along in review #7023. Fixed some feedback and it's been approved again so hopefully can get that checked in and cherry-picked to 1.6 and I'll rebase this

@estesp
Copy link
Member

estesp commented Aug 2, 2022

#7242 is merged

@thaJeztah
Copy link
Member

I'm not near a computer, but can we update go versions as well? There was a Go security release yesterday

@dcantah
Copy link
Member Author

dcantah commented Aug 2, 2022

@thaJeztah Sure. I'll open up against main, 1.6 and 1.5 and rebase after

@thaJeztah
Copy link
Member

Thank you! In case useful; it's mostly find&replace, but some branches have multiple go versions in CI. For me, especially the version used in the Dockerfiles is relevant, because our packaging script uses that version to automatically pick the Go version to use ☺️

Here's one of the previous bumps; #7159

@dcantah
Copy link
Member Author

dcantah commented Aug 2, 2022

@thaJeztah

Main: #7243
1.6: #7244
1.5: #7245

@dcantah
Copy link
Member Author

dcantah commented Aug 2, 2022

Okay, now that the Go bumps are in let me rebase, update the generated notes and add a blurb about the extra windows fix. Any other changes we need... going once... going twice... 😆

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah dcantah marked this pull request as ready for review August 2, 2022 23:07
@dcantah
Copy link
Member Author

dcantah commented Aug 2, 2022

Should be ready to go, thanks for the patience

@dmcgowan dmcgowan merged commit 5f242b5 into containerd:release/1.6 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants