New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare releases notes for 1.6.7 #7225
Conversation
Skipping CI for Draft Pull Request. |
Oh there's another Windows related change that'd be nice to get into 1.6 also #7023 |
972ef3b
to
4391d69
Compare
Is this still draft? |
@AkihiroSuda Ideally I'd like to get in #7023 and backported, had almost forgot about it. It's kind of walking the line between "backportable" however. Some folks want it fixed, but I'm not sure if anyone actually relied on the behavior today that's altered in that change, so maybe it makes sense to just land in 1.7. I'd argue what happens today is a bug however |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry for the hold up here 😐 Like I mentioned I realized it'd be nice to get in another fix we had for Windows as it was fairly far along in review #7023. Fixed some feedback and it's been approved again so hopefully can get that checked in and cherry-picked to 1.6 and I'll rebase this |
#7242 is merged |
I'm not near a computer, but can we update go versions as well? There was a Go security release yesterday |
@thaJeztah Sure. I'll open up against main, 1.6 and 1.5 and rebase after |
Thank you! In case useful; it's mostly find&replace, but some branches have multiple go versions in CI. For me, especially the version used in the Dockerfiles is relevant, because our packaging script uses that version to automatically pick the Go version to use Here's one of the previous bumps; #7159 |
Okay, now that the Go bumps are in let me rebase, update the generated notes and add a blurb about the extra windows fix. Any other changes we need... going once... going twice... 😆 |
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Should be ready to go, thanks for the patience |
See: https://gist.github.com/dcantah/7e1aef7bf809270960c2814d0d976a2b