Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.6 backport] Bump opencontainers/selinux from 1.10.0 to 1.10.1 #6878

Merged
merged 1 commit into from Apr 29, 2022
Merged

[release/1.6 backport] Bump opencontainers/selinux from 1.10.0 to 1.10.1 #6878

merged 1 commit into from Apr 29, 2022

Conversation

thaJeztah
Copy link
Member

@log1cb0mb @thaJeztah
Bump opencontainers/selinux from 1.10.0 to 1.10.1
42d691f 
Signed-off-by: Nabeel Rana <nabeelnrana@gmail.com>
(cherry picked from commit ae29594)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@kzys @estesp @mikebrow ptal

@thaJeztah thaJeztah closed this Apr 29, 2022
@thaJeztah thaJeztah reopened this Apr 29, 2022
fuweid
fuweid approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@log1cb0mb
Copy link
Contributor

@thaJeztah Is there a reason behind integration/client/go.mod not picked up but only integration/client/go.sum ?

@thaJeztah
Copy link
Member Author

@thaJeztah Is there a reason behind integration/client/go.mod not picked up but only integration/client/go.sum ?

Good eye; yes, the 1.6 branch is currently still using go mod tidy / vendor with pre-go1.17 format, so it doesn't "flatten" the indirect dependencies; because of that they're not included in the integration/client/go.mod.

mikebrow
mikebrow approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit db40e21 into containerd:release/1.6 Apr 29, 2022
@thaJeztah thaJeztah deleted the 1.6_backport_bump-opencontainers_selinux_to_v1.10.1 branch April 29, 2022 15:50
leonardoadame
leonardoadame reviewed Apr 27, 2023
View reviewed changes
Copy link

@leonardoadame leonardoadame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within.com/opencontainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoadame leonardoadame leonardoadame left review comments

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

@fuweid fuweid fuweid approved these changes

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thaJeztah @log1cb0mb @estesp @leonardoadame @mikebrow @fuweid