Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.4] vendor: github.com/opencontainers/image-spec v1.0.2 #6265

Merged
merged 1 commit into from Dec 20, 2021

Conversation

thaJeztah
Copy link
Member

  • Bring mediaType out of reserved status
  • specs-go: adding mediaType to the index and manifest structures

full diff: opencontainers/image-spec@v1.0.1...v1.0.2

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 17, 2021

Build succeeded.

@thaJeztah thaJeztah closed this Nov 18, 2021
@thaJeztah thaJeztah reopened this Nov 18, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 18, 2021

Build succeeded.

@AkihiroSuda
Copy link
Member

Let me mark this as draft until we merge the master PR #6263

@AkihiroSuda AkihiroSuda marked this pull request as draft November 18, 2021 05:22
@mikebrow
Copy link
Member

Noting the containerd/cri 1.4 release is built against image-spec v1.0.1

- Bring mediaType out of reserved status
- specs-go: adding mediaType to the index and manifest structures

full diff: opencontainers/image-spec@v1.0.1...v1.0.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Noting the containerd/cri 1.4 release is built against image-spec v1.0.1

Ahm.. good call. Looks like the vendored code works at least, but do you think we should do a sync of dependency versions in that repo?

@thaJeztah
Copy link
Member Author

#6263 was merged, so let me move this out of draft

@thaJeztah thaJeztah marked this pull request as ready for review December 10, 2021 11:37
@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 10, 2021

Build succeeded.

@dmcgowan dmcgowan added this to Needs Discussion in Code Review Dec 13, 2021
@crosbymichael crosbymichael merged commit 0475ec3 into containerd:release/1.4 Dec 20, 2021
Code Review automation moved this from Needs Discussion to Done Dec 20, 2021
@thaJeztah thaJeztah deleted the 1.4_bump_oci_spec branch December 20, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants