Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.5] Use github images for integration tests #6041

Merged
merged 1 commit into from Sep 23, 2021
Merged

[release/1.5] Use github images for integration tests #6041

merged 1 commit into from Sep 23, 2021

Conversation

dmcgowan
Copy link
Member

Backport #6032

@dmcgowan
Use github images for integration tests
1477059 
Signed-off-by: Derek McGowan <derek@mcg.dev>
(cherry picked from commit 3e72e33)
Signed-off-by: Derek McGowan <derek@mcg.dev>
@kzys
Copy link
Member

kzys commented Sep 22, 2021

The error looks new. It shouldn't be related to the change though.

FAIL
Makefile:196: recipe for target 'cri-integration' failed
./script/test/utils.sh: line 95: 20908 Terminated              keepalive "sudo PATH=${PATH} bin/containerd ${CONTAINERD_FLAGS}" ${RESTART_WAIT_PERIOD} &> ${report_dir}/containerd.log
make: *** [cri-integration] Error 1

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 22, 2021

Build succeeded.

Zyqsempai
Zyqsempai approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 4de759a into containerd:release/1.5 Sep 23, 2021
@dmcgowan dmcgowan deleted the backport-1.5-use-ghcr-test-images branch March 23, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@Zyqsempai Zyqsempai Zyqsempai approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmcgowan @kzys @Zyqsempai @AkihiroSuda