Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PipRequirement a subclass of packaging.Requirement #486

Open
eskultety opened this issue Mar 8, 2024 · 0 comments · May be fixed by #542
Open

Make PipRequirement a subclass of packaging.Requirement #486

eskultety opened this issue Mar 8, 2024 · 0 comments · May be fixed by #542
Labels
my_first_issue Good for newcomers python Pull requests that update Python code
Milestone
Refactoring: pack...

Comments

@eskultety
Copy link
Collaborator

We created our own big class which we then populate with contents from pkg_resources.Requirement. Looking at the backend implementation coming from packaging.Requirement it looks like it's very lean and hence we should be able to properly subclass our own class from that one.
@eskultety eskultety added my_first_issue Good for newcomers python Pull requests that update Python code labels Mar 8, 2024
ianrochapg pushed a commit to ianrochapg/cachi2 that referenced this issue May 7, 2024
Make PipRequirement a subclass of packaging.Requirement
b151bfd 
PipRequirement implemented pkg_resources which is very lean
and also deprecated. Removing pkg_resources and subclassing
directly from packaging.Requirement.

setuptools has been removed because it was only used by
pkg_resources, which has also been removed.

Resolves containerbuildsystem#486

Signed-off-by: Ian Rocha <iarocha@redhat.com>
@ianrochapg ianrochapg linked a pull request May 7, 2024 that will close this issue
Open
4 tasks
ianrochapg pushed a commit to ianrochapg/cachi2 that referenced this issue May 7, 2024
Make PipRequirement a subclass of packaging.Requirement
fde1d48 
PipRequirement implemented pkg_resources which is very lean
and also deprecated. Removing pkg_resources and subclassing
directly from packaging.Requirement.

setuptools has been removed because it was only used by
pkg_resources, which has also been removed.

Resolves containerbuildsystem#486

Signed-off-by: Ian Rocha <iarocha@redhat.com>
ianrochapg pushed a commit to ianrochapg/cachi2 that referenced this issue May 16, 2024
Make PipRequirement a subclass of packaging.Requirement
fe46b30 
PipRequirement implemented pkg_resources which is very lean
and also deprecated. Removing pkg_resources and subclassing
directly from packaging.Requirement.

setuptools has been removed because it was only used by
pkg_resources, which has also been removed.

Resolves containerbuildsystem#486

Signed-off-by: Ian Rocha <iarocha@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
my_first_issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Milestone
Refactoring: package managers: pip: t...
Development

Successfully merging a pull request may close this issue.

Make PipRequirement a subclass of packaging.Requirement ianrochapg/cachi2
1 participant
@eskultety