Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per_sec and eta values fluctuate wildly from one tick to the next #494

Closed
shssoichiro opened this issue Nov 14, 2022 · 3 comments
Closed

Comments

@shssoichiro
Copy link

It seems that this originated in 71e7eaa.

The previous behavior was that the per_sec and eta values would be relatively steady throughout the life of the progress bar, as they simply calculated pos / (now - start_time).

The new behavior instead calculates (pos - prev_pos) / (now - prev_time). Since this no longer has the effect of averaging out fast and slow spikes since the start of the progress bar, it causes the values in per_sec and eta to fluctuate wildly between each tick. In my opinion, this is undesirable.

@djc
Copy link
Collaborator

djc commented Nov 15, 2022

I think this is the discussion in #394. It could really use someone to dig in and come up with a good plan, and I'm not sure I'll have time for that in the near term.

@teor2345
Copy link

Closed by #539?

@djc djc closed this as completed Jun 28, 2023
@djc
Copy link
Collaborator

djc commented Jun 28, 2023

Probably! If not, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants