Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix percent initial value when there is no length #491

Merged
merged 2 commits into from Nov 6, 2022
Merged

Fix percent initial value when there is no length #491

merged 2 commits into from Nov 6, 2022

Conversation

devmatteini
Copy link
Contributor

Fixes #489

@djc
Copy link
Collaborator

djc commented Nov 5, 2022

Seems reasonable, thanks for looking into it!

@devmatteini
Copy link
Contributor Author

The lint errors seem unrelated, but I can fix them if you want

@djc
Copy link
Collaborator

djc commented Nov 5, 2022

Would be great, thanks!

@djc djc merged commit 8e220fd into console-rs:main Nov 6, 2022
@devmatteini devmatteini deleted the percent_initial_value branch November 6, 2022 17:14
@djc djc mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

percent in ProgressStyle template starts from 100% instead of 0%
2 participants
@devmatteini @djc