Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove write_all from ProgressBarIter's Write trait #478

Merged
merged 1 commit into from Sep 5, 2022

Conversation

hexagonal-sun
Copy link
Contributor

@hexagonal-sun hexagonal-sun commented Sep 3, 2022

By implementing write_all we lose granularity of progress updates
that are captured from write. Therefore, remove this function. This also brings the ProgressBarIter's Write trait into line with the Read trait since that doesn't provide an implementation of read_all.

By implementing `write_all` we loose granularity of progress updates
that are captured from `write`.  Therefore, remove this function.
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@djc djc merged commit a466096 into console-rs:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants