Remove the extra space, and make the wide element fill the whole term…

[sigmaSd]

…inal width

fix #348
fix #342 again

Recap of the situation:

• Don't add an extra line after the progress bar #338 removed the extra line that indicatif always adds
• But now issue like A newline character should be printed after completion #342 happens
• Initially I thought just adding an extra space is a good idea to fill the width
• But that looks weird, so the new solution is to increase the wide elements size to fill the terminal width

If no wide elements is used, any printing after will happen on the same line as the progress bar, this might be not what users expects but I think its a desirable change, and reverting to the old behavior is a simple as adding println!() after the progress bar

[djc]

What happens if there is no wide element?

[sigmaSd]

if there is no wide element,

• the bar wont fill the terminal width
• there is no ending new line

The next prints will be on the same line

[djc]

if there is no wide element,

* the bar wont fill the terminal width
* there is no ending new line

The next prints will be on the same line

So that doesn't sound like what we want. Maybe in absence of a wide element maybe we should have a sort of virtual wide element that fills the line up with spaces?

[sigmaSd]

I personaly prefer to leave that to the user

What If I actually want to print on the same line, cool that just works

What if I want the old behaivour and print on the next line, simple add println!() and then print what I actually want

Other ideas I thought about is println!() on Progressbar drop but that gets not easy when considering multi progressbar, thats why I adovocate the above for its simplicity

[sigmaSd]

I guess the virtual space is also possible but it means that the cursor will always be locked to the right edge of the terminal, which might also look weird

[djc]

Isn't that what it already looks like if we have a wide element today (or after this PR)?

[sigmaSd]

I mean if there is no wide element:

• on master branch, the cursor ia one space away from the bar
• with this pr, the cursor is at the end of the bar
• with the idea of virtual space, the cursor is always at the right terminal end no matter the width of the bar

Wide elemnts actually hide these differences since they fill the entire width

[djc]

The question is how this compares to the situation pre-#338. It seems to me that pre-#338, the cursor always ended up in the first column of the line after the progress bar. IMO changing that to have the cursor consistenly in the last column of the progress bar line seems the best approach. I don't see much virtue in having the cursor be directly after the bar if the bar is non-wide.

[sigmaSd]

That's reasonable, I added a commit with your suggestion.

[djc]

Thanks!