Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add an extra line after the progress bar #338

Merged
merged 1 commit into from Dec 30, 2021
Merged

Don't add an extra line after the progress bar #338

merged 1 commit into from Dec 30, 2021

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Dec 29, 2021

Fix #334

The math seems to checkout, but I can't be 100 % confidant

  • I prefer not to change console because this current behavior could be relied on by crates
  • I'm using write_str which is doc_hidden is that ok?

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 29, 2021

  • I did not test on windows

@djc djc merged commit e46ca83 into console-rs:main Dec 30, 2021
@djc
Copy link
Collaborator

djc commented Dec 30, 2021

Seems okay, thanks!

@redzic redzic mentioned this pull request Dec 30, 2021
Closed
@sigmaSd sigmaSd mentioned this pull request Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra line after the progress bar
2 participants
@sigmaSd @djc