Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.17.0 release planning #318

Closed
jqnatividad opened this issue Oct 26, 2021 · 17 comments
Closed

0.17.0 release planning #318

jqnatividad opened this issue Oct 26, 2021 · 17 comments

Comments

@jqnatividad
Copy link
Contributor

jqnatividad commented Oct 26, 2021

There have been a lot of changes since 0.16.2 was released in May 2021.

0.16.2...main

Thanks for this awesome library!

@djc
Copy link
Collaborator

djc commented Oct 26, 2021

Yup, I think I'll put out a new release soon.

@djc
Copy link
Collaborator

djc commented Dec 15, 2021

Sorry this is taking so long. At this point I'm planning to put out an rc with a call for testing after #331 is merged.

@firasuke
Copy link
Contributor

firasuke commented Jan 2, 2022

I'm also waiting for a new release to use the new #301 feature.

@djc
Copy link
Collaborator

djc commented Jan 2, 2022

I've published 0.17.0-rc.1, please test and 👍 this comment if it works for you!

@jqnatividad
Copy link
Contributor Author

jqnatividad commented Jan 31, 2022

Hi @djc,
I'm testing 0.17.0-rc.1 and I found per_secs is still showing too many digits which was fixed in #313 back in September.
I can't seem to find the git tag/branch for 0.17.0-rc.1 which was published on crates.io Jan 2.
At which commit-id was 0.17.0-rc.1 on?
Thanks!

@djc
Copy link
Collaborator

djc commented Feb 1, 2022

Hey @jqnatividad, good question. Looks like I never even pushed the version bump to GitHub. Anyway, I've merged those changes into main now and pushed a tag. I also just published -rc.2 (and a tag for it).

@wbogocki
Copy link
Contributor

wbogocki commented Feb 2, 2022

This is the output for 0.17.0-rc.2 for me, can make an issue if you'd like:

[#                   ] 0% 🥌 2421/525600 (216061.0691/s) ⏱ 00:00:00 (ETA 00:00:02) | Doing stuff...                                                                                                                                                                                                        [#                   ] 4% 🥌 19922/525600 (275073.6029/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                       [##                  ] 7% 🥌 38170/525600 (274012.4835/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                       [###                 ] 11% 🥌 56357/525600 (268608.7784/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                      [###                 ] 14% 🥌 74228/525600 (265776.8413/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                      [####                ] 17% 🥌 91943/525600 (264486.1798/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                      [#####               ] 21% 🥌 109530/525600 (263163.4676/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[#####               ] 24% 🥌 127014/525600 (262198.9122/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[######              ] 27% 🥌 144495/525600 (262155.9439/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[#######             ] 31% 🥌 161966/525600 (262401.5976/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[#######             ] 34% 🥌 179478/525600 (263230.3474/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[########            ] 37% 🥌 197030/525600 (262241.7944/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[#########           ] 41% 🥌 214512/525600 (262512.2539/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[#########           ] 44% 🥌 232013/525600 (261348.6250/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[##########          ] 47% 🥌 249437/525600 (261426.8914/s) ⏱ 00:00:00 (ETA 00:00:01) | Doing stuff...                                                                                                                                                                                                     
[###########         ] 51% 🥌 266861/525600 (260778.5318/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[###########         ] 54% 🥌 284235/525600 (260765.6675/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[############        ] 57% 🥌 301616/525600 (260679.6394/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[#############       ] 61% 🥌 318988/525600 (260369.8677/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[#############       ] 64% 🥌 336349/525600 (260590.4877/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[##############      ] 67% 🥌 353723/525600 (260700.9683/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[###############     ] 71% 🥌 371106/525600 (260367.0554/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[###############     ] 74% 🥌 388465/525600 (260226.9450/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[################    ] 77% 🥌 405804/525600 (259551.2855/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[#################   ] 80% 🥌 423098/525600 (259005.1505/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[#################   ] 82% 🥌 431731/525600 (258381.1758/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[##################  ] 85% 🥌 448942/525600 (257905.5575/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[##################  ] 89% 🥌 466110/525600 (256801.1114/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[################### ] 92% 🥌 483227/525600 (256387.1104/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[####################] 95% 🥌 500304/525600 (256196.1187/s) ⏱ 00:00:01 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[####################] 97% 🥌 508843/525600 (254384.1073/s) ⏱ 00:00:02 (ETA 00:00:00) | Doing stuff...                                                                                                                                                                                                     
[####################] 100% 🥌 525600/525600 (254454.6886/s) ⏱ 00:00:02 (ETA 00:00:00) | Finished       

@sigmaSd
Copy link
Contributor

sigmaSd commented Feb 2, 2022

@wbogocki it would be great if you make an issue with the code and terminal/os version

@wbogocki
Copy link
Contributor

wbogocki commented Feb 2, 2022

Done :) Let me know if you need more info.

@djc
Copy link
Collaborator

djc commented Feb 10, 2022

I've just published rc.3. Barring any reported regressions I'll probably publish the 0.17.0 release tomorrow.

@djc
Copy link
Collaborator

djc commented Feb 10, 2022

Published rc.4 to deal with a regression (#368) and squeezed in a further performance enhancement (see #363). Still inclined to release tomorrow barring any further regression reports.

@djc
Copy link
Collaborator

djc commented Feb 22, 2022

Published rc.5. Really hoping to wrap this up soon.

@djc
Copy link
Collaborator

djc commented Jul 26, 2022

@chris-laplante I'm inclined to push out the final release nowish. Any concerns? As far as I can tell the multi-line things (#443 and #447) won't affect the public API, and I think #447 is not a regression?

@chris-laplante
Copy link
Collaborator

@chris-laplante I'm inclined to push out the final release nowish. Any concerns? As far as I can tell the multi-line things (#443 and #447) won't affect the public API, and I think #447 is not a regression?

Yes I'd agree :). #447 is not a regression AFAICT.

@djc djc changed the title Time for a new release? 0.17.0 release planning Jul 28, 2022
@djc djc pinned this issue Jul 28, 2022
@djc
Copy link
Collaborator

djc commented Jul 28, 2022

@chris-laplante I've written up release notes: https://github.com/console-rs/indicatif/releases/tag/0.17.0-rc.11. Would you be able to review them?

@chris-laplante
Copy link
Collaborator

@chris-laplante I've written up release notes: https://github.com/console-rs/indicatif/releases/tag/0.17.0-rc.11. Would you be able to review them?

Nice writeup! Looks good to me :)

@djc
Copy link
Collaborator

djc commented Jul 30, 2022

Released! Thanks everyone for their help!

@djc djc closed this as completed Jul 30, 2022
@djc djc unpinned this issue Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants