Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AsyncBufRead implementation for ProgressBarIter #315

Merged
merged 7 commits into from Oct 11, 2021
Merged

Add AsyncBufRead implementation for ProgressBarIter #315

merged 7 commits into from Oct 11, 2021

Conversation

x0f5c3
Copy link
Contributor

@x0f5c3 x0f5c3 commented Oct 2, 2021

Added AsyncBufRead implementation for ProgressBarIter<W: tokio::io::AsyncBufRead + tokio::io::AsyncRead + Unpin>

djc
djc reviewed Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense! Suggestion for a different way to write it:

src/iter.rs Outdated Show resolved Hide resolved
src/iter.rs Show resolved Hide resolved
src/iter.rs Outdated Show resolved Hide resolved
@djc djc merged commit 5930988 into console-rs:main Oct 11, 2021
@djc
Copy link
Collaborator

djc commented Oct 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@x0f5c3 @djc