Pass through stream_position in ProgressBarIter #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids sending a stream_position update and also preserves optimizations that the underlying object may have made for stream_position.
For example, when wrapping a
BufReader
object, adding this impl allows the use of.stream_position()
in functions that take a genericSeek
object without causing the performance drop associated with the default impl ofstream_position
callingseek(SeekFrom::Current(0))
and throwing away the buffer each time.