Added AsyncRead and AsyncWrite support for ProgressBar #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite methods for ProgressBar and implemented AsyncRead, AsyncWrite and AsyncSeek for ProgressBarIter
|
Thanks, this seems reasonable! (I wrote some remarks about tests here that didn't make sense.) Can you fix up the lint CI job? |
|
I think the CI job should pass now since I moved the async related uses under |
|
Just a little formatting left. |
|
Sorry for that, forgot to run cargo fmt, should be fixed now |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for tokio Read, Write and Seek traits to allow for using the ProgressBar with tokio async io traits by wrapping them in ProgressBarIter.