Adding ProgressIterator::progress_with_style() and taking care of minor typos and clippy lints #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style a ProgressIterator without manually handling the length of the bar
Removing two needless borrows
djc
approved these changes
Aug 9, 2021
|
Looks great, thanks! |
|
Cool! I forgot one thing, though: With this in place, perhaps the snippet in the documentation that led me here in the first place could/should also be updated, since it still shows |
Styling iterators should also be possible for parallel iterators
Change snippet about styling ParallelProgressIterator
|
Would you mind fixing the final clippy lint issue, too? Thanks! |
Removing needless borrows
|
I squashed your commits a little bit and rebased them onto main. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
ProgressIterator::progress_with_style(), as discussed in #305. Further, I have corrected a small typo and taken care of two clippy warnings.Resolves #305