Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't distinguish between checked and unchecked items #202

Closed
cryeprecision opened this issue May 23, 2022 · 2 comments · Fixed by #275
Closed

Can't distinguish between checked and unchecked items #202

cryeprecision opened this issue May 23, 2022 · 2 comments · Fixed by #275
Labels
c-theme Context: Theme

Comments

@cryeprecision
Copy link

When using the ColorfulTheme, the tick-symbol (✔/✔) is shown as an emoji.
Therefore the color is not shown anymore and you can't distinguish between checked and unchecked.

I have this problem on Windows 10 21H1 when using Windows Terminal.

A solution would be to change the prefix for unchecked items to (❌/❌) or something similar.

https://github.com/mitsuhiko/dialoguer/blob/3f16bdedf885d98a90273bd57ec243d71da1b462/src/theme.rs#L336-L337
@pksunkara pksunkara added the c-theme Context: Theme label May 29, 2022
@alex19EP
Copy link

alex19EP commented Sep 5, 2022

I think #152 will fix this.

@pksunkara pksunkara linked a pull request Sep 5, 2022 that will close this issue
use distinct symbols for selection #152
Closed
@mirumirumi
Copy link

I have the same problem.
I am hoping #152 will be merged.

@Gordon01 Gordon01 mentioned this issue Aug 30, 2023
Merged
@pksunkara pksunkara linked a pull request Sep 1, 2023 that will close this issue
Change chars for MultiSelect items #275
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-theme Context: Theme
Projects
None yet
Milestone
No milestone
4 participants
@pksunkara @alex19EP @cryeprecision @mirumirumi