Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

white isn't white #177

Open
ToBinio opened this issue Jul 28, 2023 · 1 comment · May be fixed by #199
Open

white isn't white #177

ToBinio opened this issue Jul 28, 2023 · 1 comment · May be fixed by #199

Comments

@ToBinio
Copy link

ToBinio commented Jul 28, 2023

When using the color white it isn't really white instead it's more a light gray.
here is a table of the 256 colors.

currently, only the first 8 (0-7) are used and white is mapped to 7 which isn't white

it would probably be good to add the first 16 colors to the color enum.

note:
if you are ok with this change I could do the change myself and open a PR
@joshka
Copy link
Contributor

joshka commented Jan 11, 2024

White is the name of from ECMA-48 SGR 37, so in theory the name is correct.

In many terminal color schemes this this is rendered as a light grey color (and some libraries refer to this specifically as Grey for this reason).

In practice, the color you want is Bright White (.bright().white().

I'm not a maintainer here, but a maintainer of the Ratatui crate (which uses Grey because of historical reasons).
I think adding the bright colors to the enum would likely be a good idea, but renaming the color would be bad as it perpetuates more wrongly named colors even though they are more perceptually correct.

tiberiugila added a commit to tiberiugila/console that referenced this issue Jan 20, 2024
@tiberiugila
Fixed console-rs#177
fb500de
@tiberiugila tiberiugila linked a pull request Jan 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joshka @ToBinio