Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor code cleanups #47

Merged
merged 2 commits into from Jun 18, 2020

Conversation

nicokoch
Copy link
Contributor

  • Fix wrong identation
  • Make error handling more idiomatic

  - Fix wrong identation
  - Make error handling more idiomatic
@conradkleinespel
Copy link
Owner

Hey @nicokoch ! Thanks for this 👍 and sorry for not replying earlier 😬

I'll have a look at this soon and merge.

@conradkleinespel conradkleinespel mentioned this pull request Jun 18, 2020
@conradkleinespel conradkleinespel merged commit acff1bd into conradkleinespel:master Jun 18, 2020
@conradkleinespel
Copy link
Owner

Thanks @nicokoch ! I'll have a look at the last open PR this weekend and then merge/publish. Until then, you can use the git way of defining dependencies if needed:

[dependencies]
rpassword = { git = "https://github.com/conradkleinespel/rpassword", rev = "acff1bd" }

ValliereMagic pushed a commit to ValliereMagic/rpassword that referenced this pull request Jun 26, 2023
* Various minor code cleanups
  - Fix wrong identation
  - Make error handling more idiomatic

* Remove an unneeded if let
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants