Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade clap to remove dependency on unmaintained atty crate #84

Closed
esimkowitz opened this issue Jul 13, 2023 · 2 comments
Closed

Upgrade clap to remove dependency on unmaintained atty crate #84

esimkowitz opened this issue Jul 13, 2023 · 2 comments
Labels
fixed in master This issue has been resolved, but the change hasn't been released to crates.io

Comments

@esimkowitz
Copy link

I have been getting component governance alerts for Grass due to its nested dependency on atty, which has been unmaintained for a few years now and has some compatibility issues with Windows. Your nested dependency on atty comes from clap, though they've moved away from atty as of last year (see clap-rs/clap#4249).

Here's a link to the advisory in the GitHub Security Advisory Database: GHSA-g98v-hv3f-hcfr
@connorskees
Copy link
Owner

I've been putting off updating clap for a while. I agree the warning is quite annoying. I've updated the clap version in master, and this change should be released to crates.io quite soon as 0.13.1. I'll note that the MSRV of this crate has to increase to 1.64.0 in order to work with the newest version of clap. Unfortunately the change you linked was not backported to 3.x.x.

@connorskees connorskees added the fixed in master This issue has been resolved, but the change hasn't been released to crates.io label Jul 14, 2023
@simon-bourne simon-bourne mentioned this issue Jul 16, 2023
Closed
@connorskees
Copy link
Owner

This change has been released to crates.io as 0.13.1. Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed in master This issue has been resolved, but the change hasn't been released to crates.io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esimkowitz @connorskees