Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gitpython dependency optional? #296

Open
bollwyvl opened this issue Dec 14, 2022 · 6 comments · Fixed by #297
Open

Make gitpython dependency optional? #296

bollwyvl opened this issue Dec 14, 2022 · 6 comments · Fixed by #297

Comments

@bollwyvl
Copy link
Contributor

#204's adding the hard dep on gitpython lights up vulnerability scanners for CVE-2022-24439. Here's the upstream issue:

As there's no particular timeline for a fix, perhaps the gitpython dependency could be made optional, as with pip for the non-vendored bits of poetry?

@bollwyvl
Copy link
Contributor Author

Strawman PR up in #297.

mariusvniekerk added a commit that referenced this issue Dec 15, 2022
@bollwyvl
Copy link
Contributor Author

Thanks!

@bollwyvl
Copy link
Contributor Author

CVE-2024-22190 is up. can we reconsider the hard dep, and make it an extra?

@maresb
Copy link
Contributor

maresb commented Jan 12, 2024

Ugh, yes, given the history I think making it an extra makes a lot of sense.

@maresb maresb reopened this Jan 12, 2024
@bollwyvl
Copy link
Contributor Author

As mentioned before: as of now, conda install conda-lock pulls in 85 transient deps. I'd really like to see a conda-lock-explicit, which:

  • pulled in as few dependencies as possible
  • exposed only a bare-bones argparse CLI, if any
  • read (multiple) environment.yml files
  • generated @EXPLICIT files
    • without clever magic comments
    • portable to all conda-compatible clients, constructor, SBOM tools, etc.

Pretty much everything else could be an entry_point-driven plugin.

@maresb
Copy link
Contributor

maresb commented Jan 13, 2024

@bollwyvl, Seems like a bit of a project, but I'd totally support that. I think it'd help a lot with code quality too. I don't really have any time to push it forward right now though.

@mariusvniekerk, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants