Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching environment instructions #200

Merged
merged 9 commits into from Nov 24, 2021

Conversation

epassaro
Copy link
Contributor

@epassaro epassaro commented Nov 20, 2021

Provided instructions on how to cache deployed environments for Miniforge variants.

@epassaro
Copy link
Contributor Author

Hi @goanpeca, these are my changes.

@EwoutH
Copy link

EwoutH commented Nov 23, 2021

Great addition, thanks!

@goanpeca
Copy link
Member

Hi @epassaro thanks for this.

Could you on top of this add an actual example that runs like the others?

See https://github.com/conda-incubator/setup-miniconda/tree/master/.github/workflows

@epassaro
Copy link
Contributor Author

Yes, sure.

@epassaro
Copy link
Contributor Author

Added the example, needs approval to run @goanpeca

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@epassaro epassaro force-pushed the cache-readme branch 2 times, most recently from c3d321e to 169ba14 Compare November 23, 2021 19:20
README.md Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

Thank you so much @epassaro! We can merge once the CI is passing!

@jaimergp jaimergp merged commit 27743c3 into conda-incubator:master Nov 24, 2021
@avaldebe avaldebe mentioned this pull request Jan 11, 2022
@jonashaag
Copy link
Contributor

This doesn't seem to work as advertised. The DATE env var isn't taken into account:

win-64-conda-95d949d6b25a373b614d944993ac0d3be055e69ebfaf5fae91173f00c5b4106d--0

There should be a date between the last two -.

@epassaro
Copy link
Contributor Author

This doesn't seem to work as advertised. The DATE env var isn't taken into account:

win-64-conda-95d949d6b25a373b614d944993ac0d3be055e69ebfaf5fae91173f00c5b4106d--0

There should be a date between the last two -.

I realized that the unix command date doesn't work on Windows. I need to add some logic in order to make it work for all the OSes. Please open an issue.

@jonashaag
Copy link
Contributor

See #212

@goanpeca goanpeca added this to the v2.2.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants