Skip to content

GitLab auth uses full name instead of username as user ID, allowing impersonation

Critical
vito published GHSA-627p-rr78-99rj Aug 11, 2020

Package

github.com/concourse/dex

Affected versions

<= 6.4.0

Patched versions

>= 6.4.1, 6.3.1

Description

Impact

Installations which use the GitLab auth connector are vulnerable to identity spoofing by way of configuring a GitLab account with the same full name as another GitLab user who is granted access to a Concourse team by having their full name listed under users in the team configuration or given to the --gitlab-user flag.

See the GitLab auth docs for details.

Concourse installations which do not configure the GitLab auth connector are not affected.

Patches

Concourse v6.3.1 and v6.4.1 were both released with a fix on August 4th, 2020.

Both versions change the GitLab connector to use the username, rather than the full name. This was always the intent, and the previous behavior was originally reported as a bug (concourse/dex#7) prior to being reported as a security issue.

Any Concourse teams which configure GitLab users will have to switch each user from their full name to their username upon upgrading to these versions.

Workarounds

GitLab groups do not have this vulnerability, so GitLab users may be moved into groups which are then configured in the Concourse team.

References

For more information

If you have any questions or comments about this advisory, you may reach us privately at concourseteam+security@gmail.com.

Severity

Critical

CVE ID

CVE-2020-5415

Weaknesses

No CWEs

Credits