Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aborting build does nothing when build runs in put step for pool resource #8462

Open
xtremerui opened this issue Jun 30, 2022 · 2 comments · May be fixed by #8479
Open

Aborting build does nothing when build runs in put step for pool resource #8462

xtremerui opened this issue Jun 30, 2022 · 2 comments · May be fixed by #8479
Labels
bug regression
Milestone
v7.9.0

Comments

@xtremerui
Copy link
Contributor

xtremerui commented Jun 30, 2022 •
edited

Summary

When putting a pool-resource, the build can't not be aborted

Screen Shot 2022-06-30 at 5 24 13 PM

Steps to reproduce

Config a pipeline containes a pool resource and add a job with the resource in put-step. While the put step runs, try cancel the build by top right cancel button or fly cli abort-build cmd.

Expected results

Build can be aborted

Actual results

Build still runs

Additional context

Even ssh into the put step and kill the put process won't allow the step to be completed

  • Concourse version: 7.8.1
  • Browser (if applicable):
  • Did this used to work? Yes. Verified it was working by v7.4.4
@xtremerui
Copy link
Contributor Author

@evanchaoli this is the example we have in hush-house. Seems like it only happens for pool-resource.

@navdeep-pama navdeep-pama added this to the v7.8.2 milestone Jul 4, 2022
@xtremerui
Copy link
Contributor Author

xtremerui commented Jul 12, 2022 •
edited

Run a test pipeline on older versions and found the issue was introduced on v7.5.0.

The last log after aborting the build is

{"timestamp":"2022-07-12T20:32:49.343640500Z","level":"info","source":"atc","message":"atc.tracker.notify.run.aborting","data":{"build":"1","build_id":1,"job":"do-nothing","pipeline":"test","session":"24.7.2","team":"main"}}

@xtremerui xtremerui modified the milestones: v7.8.2, v7.9.0 Jul 13, 2022
@xtremerui xtremerui linked a pull request Jul 14, 2022 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging a pull request may close this issue.

Unblock process deletion in worker runtime concourse/concourse
2 participants
@xtremerui @navdeep-pama