Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conan-center] Check exported patches are the same ones listed in conandata #435

Open
danimtb opened this issue Jul 13, 2022 · 1 comment

Comments

@danimtb
Copy link
Member

danimtb commented Jul 13, 2022

Now, I'm seeing this pattern in many recipes:

    def export_sources(self):
        self.copy("CMakeLists.txt")
        for patch in self.conan_data.get("patches", {}).get(self.version, []):
            self.copy(patch["patch_file"])

The recipe is taking care of exporting only the patches it is going to use. Maybe this hook is no longer needed.

That's great then! Probably we have to document this as good practice, so it is easy to check by reviewers or maybe have a hook check that makes sure that the files listed in the reduced conandata are exactly the same ones exported.

Originally posted by @danimtb in #218 (comment)

@prince-chrismc
Copy link
Contributor

CCI docs: conan-io/conan-center-index#11982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants