Add file:/// handling in download tool #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jul 6, 2022
SSE4
reviewed
Jul 6, 2022
| @@ -127,9 +129,13 @@ Examples: | |||
| # Download and check file checksum | |||
| download(self, "http://someurl/somefile.zip", "myfilename.zip", md5="e5d695597e9fa520209d1b41edad2a27") | |||
|
|
|||
| # Retrieve file that is visible in the local filesystem | |||
| tools.download("file:///home/myuser/downloads/somefile.zip", "myfilename.zip", md5="e5d695597e9fa520209d1b41edad2a27") | |||
There was a problem hiding this comment.
- an example with Windows path (e.g. with C: drive) would be useful
- does it work with relative path? if so, what are they relative to?
There was a problem hiding this comment.
I agree with those, clarifying that would be nice
czoido
approved these changes
Jul 26, 2022
|
I've added an example of a windows path ( Relative references as per RFC 8089 only make sense in the context of a "base" URI - I imagine that's intended for web pages that are loaded from a URI that contain links relative to the current page, where the browser resolves the relative reference to a URI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for conan-io/conan#11569
Ability for
conan.tools.files.get()andconan.tools.files.download()to retrieve files from the local filesystem referenced with afile:///URI.