Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentence formation - grammar #2187

Merged
merged 1 commit into from Aug 11, 2021
Merged

sentence formation - grammar #2187

merged 1 commit into from Aug 11, 2021

Conversation

nirmalnirav
Copy link
Contributor

Going through the docs, I found an unusual sentence formation in the file export.rst. This is my first contribution to any open source project ever!

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2021

CLA assistant check
All committers have signed the CLA.

@danimtb
Copy link
Member

danimtb commented Aug 9, 2021

Hi @nirmalnirav and thanks for the contribution.

This reference text is copied here from the conan export --help command output, and it is actually wrong there as well. So we should fix the help message in the conan client source code first.

@nirmalnirav
Copy link
Contributor Author

Hello @danimtb ,

going into the source code will be out of my scope. Shall I create a github issue referencing this pull request? Or shall I leave it altogether?

Thanks and regards
Nirav

@danimtb
Copy link
Member

danimtb commented Aug 10, 2021

Don't worry @nirmalnirav, I will take care of that and let you know. Thank you very much for taking the time to contribute 😄

@danimtb danimtb mentioned this pull request Aug 10, 2021
5 tasks
@danimtb
Copy link
Member

danimtb commented Aug 10, 2021

Here you go: conan-io/conan#9408
Will be merged for the next Conan client release. Thank you!

@danimtb danimtb added this to the 1.40 milestone Aug 10, 2021
@czoido czoido merged commit 26357d2 into conan-io:develop Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants