Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing private dependencies in CMakeDeps and MSBuildDeps #9517

Merged
merged 5 commits into from Sep 2, 2021
Merged

Fixing private dependencies in CMakeDeps and MSBuildDeps #9517

merged 5 commits into from Sep 2, 2021

Conversation

memsharded
Copy link
Member

Changelog: Fix: Adding management of private dependencies, via new visible trait compatible with 2.0 for new CMakeDeps and MSBuildDeps.
Docs: Omit

Fix #9514

@memsharded memsharded added this to the 1.40 milestone Sep 1, 2021
@memsharded memsharded mentioned this pull request Sep 1, 2021
Closed
@memsharded memsharded merged commit 2c94b9c into conan-io:develop Sep 2, 2021
@memsharded memsharded deleted the fix/toolchain_msbuildeps_private branch September 2, 2021 12:22
@memsharded memsharded mentioned this pull request Sep 9, 2021
Open
@aucampia
Copy link

was the origin) file in here intentional or accidental?

@memsharded
Copy link
Member Author

memsharded commented Sep 23, 2021 •
edited

Opps, clearly an accident, thanks for telling.

I'll remove it in next PR, no need to burn more CI for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

@czoido czoido czoido approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.

[bug] Possible issue with property sheet generation
4 participants
@memsharded @aucampia @lasote @czoido