Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/clang #9477

Merged
merged 22 commits into from Aug 30, 2021
Merged

Feature/clang #9477

merged 22 commits into from Aug 30, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Aug 25, 2021

Changelog: Feature: Testing support for Windows CMake + Clang (independent LLVM, not VS) + Ninja/MinGW builds, and CMake + Clang (Visual Studio 16 internal LLVM 11 via ClangCL toolset).
Docs: Omit

Address: #9295

@memsharded memsharded marked this pull request as ready for review August 27, 2021 22:39
@memsharded
Copy link
Member Author

@czoido clang in Windows in CI is not installed yet, but this can be a separate feature.

@czoido czoido merged commit 7c4c9ce into conan-io:develop Aug 30, 2021
@memsharded memsharded deleted the feature/clang branch August 30, 2021 11:32
@@ -515,6 +515,12 @@ def _get_toolset(self, generator):
return "version=14.{}".format(minor)
else:
return "v14{}".format(minor)
elif compiler == "clang":
if generator and "Visual" in generator:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why cannot we use other generators such as cmake ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the CMake generator. You need to select one of the CMake supported ones: MinGW Makefiles, Visual Studio XX YYYY, etc.

Also, CMakeToolchain will only support the CMakeDeps generator (based on find_package()), but not the legacy cmake, cmake_find_package[_multi], becase these later ones will be removed in 2.0.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I got it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants