Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake include_guard() for cmake toolchain #8728

Merged
merged 2 commits into from Mar 29, 2021

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Mar 29, 2021

Add include_guard support when CMake version is >= 3.10. Otherwise, use old sentinels approach.

Changelog: Feature: CMake toolchain supports include_guard() feature
Docs: Omit

closes #8639

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: James <james@conan.io>
@memsharded memsharded added this to the 1.35 milestone Mar 29, 2021
@memsharded memsharded merged commit 4619476 into conan-io:develop Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Consider using CMake's include_guard() in conan_toolchain.cmake
2 participants