Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qbs install #8660

Merged
merged 1 commit into from Mar 22, 2021
Merged

Fix qbs install #8660

merged 1 commit into from Mar 22, 2021

Conversation

Psy-Kai
Copy link
Contributor

@Psy-Kai Psy-Kai commented Mar 17, 2021

Currently the qbs build helper installed its files into conanfile.install_folder. With this PR the files are installed directly in the conanfile.package_folder like cmake does.

Changelog: Fix: Build helper qbs install now installs directly into package_folder.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@memsharded memsharded added this to the 1.35 milestone Mar 22, 2021
@memsharded
Copy link
Member

Thanks for continuing on this.
The truth is that the target folders is not always clear, we are working trying to improve this, making it a bit more explicit, please keep tuned.

Merging this for next 1.35

@memsharded memsharded merged commit 0d0f256 into conan-io:develop Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants