Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove sh from path in the new CMake helper #8625

Merged
merged 13 commits into from Mar 23, 2021

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Mar 10, 2021

Changelog: Feature: Do not remove sh from the path in the new CMake helper.
Docs: conan-io/docs#2055

#TAGS: slow

  • Refer to the issue that supports this Pull Request: closes Remove removal of "sh" from path for MinGW in CMake #8597
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb added this to the 1.35 milestone Mar 10, 2021
@danimtb danimtb self-assigned this Mar 10, 2021
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes to develop2 branch! Update: My bad, it is good in develop, it only affects new CMake tools

It will need the CMAKE-SH_NOTFOUND, maybe this is not sufficiently covered by tests, I would expect something to fail. Maybe it is a "slow" test?

@danimtb
Copy link
Member Author

danimtb commented Mar 10, 2021

I was expecting the test added here or other ones using mingw to fail with this PR but it is not happening. The Ci is using CMake 3.17.3 (https://ci.conan.io/blue/organizations/jenkins/ConanTestSuite/detail/PR-8625/4/pipeline/307/#step-355-log-1441) that do not raise error if ssh is in the path (it was fixed in CMake 3.17.0 https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3978).

We need to run a lower version in the CI in order to test this properly.

@danimtb danimtb marked this pull request as ready for review March 23, 2021 13:38
@danimtb danimtb requested a review from memsharded March 23, 2021 13:38
@danimtb danimtb assigned memsharded and unassigned danimtb Mar 23, 2021
@memsharded memsharded merged commit 37343e9 into conan-io:develop Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove removal of "sh" from path for MinGW in CMake
3 participants