New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not remove sh from path in the new CMake helper #8625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes to Update: My bad, it is good in develop2
branch!develop
, it only affects new CMake tools
It will need the CMAKE-SH_NOTFOUND, maybe this is not sufficiently covered by tests, I would expect something to fail. Maybe it is a "slow" test?
I was expecting the test added here or other ones using mingw to fail with this PR but it is not happening. The Ci is using CMake 3.17.3 (https://ci.conan.io/blue/organizations/jenkins/ConanTestSuite/detail/PR-8625/4/pipeline/307/#step-355-log-1441) that do not raise error if ssh is in the path (it was fixed in CMake 3.17.0 https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3978). We need to run a lower version in the CI in order to test this properly. |
Changelog: Feature: Do not remove sh from the path in the new CMake helper.
Docs: conan-io/docs#2055
#TAGS: slow
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.