Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toos.OsInfo: properly detect amazon linux 2 #8612

Merged
merged 1 commit into from Mar 19, 2021
Merged

toos.OsInfo: properly detect amazon linux 2 #8612

merged 1 commit into from Mar 19, 2021

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Mar 8, 2021

This should fix turtlebrowser/turtlebrowser#58
/etc/os-release has the following content:

NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"

Changelog: Bugfix: Properly detect Amazon Linux 2 distro.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@ericLemanissier
Copy link
Contributor Author

all green ! WDYT of this change ?

@memsharded memsharded added this to the 1.35 milestone Mar 19, 2021
@memsharded memsharded merged commit 1c70ae9 into conan-io:develop Mar 19, 2021
@memsharded
Copy link
Member

Thanks for contributing this, it will be in next 1.35 release

@ericLemanissier ericLemanissier deleted the patch-1 branch March 19, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AmazonLinux 2 build errors
3 participants