New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new conan.tools.files #8550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
config = conanfile.conf | ||
|
||
# It might be possible that users provide their own requester | ||
retry = retry if retry is not None else int(config["tools.files.download"].retry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be discussed: if recipe defines retry=1, that is hardcoded. Trying to configure it downstream in [conf] will have no effect, I am not sure about this.
We are good as-is now, but we want to review this later.
Co-authored-by: James <james@conan.io>
Changelog: Feature: Create new conan.tools.files for 2.0.
Docs: omit
Now conan.tools.file will have load, save, mkdir, download, get, ftp_download in the beginning.