Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow conan new templates to contain Readme.md and LICENSE.txt files #11645

Merged
merged 1 commit into from Jul 26, 2022

Conversation

stefansli
Copy link
Contributor

@stefansli stefansli commented Jul 14, 2022

This is just a small fix. I didn't find an issue for this and I don't think an issue is needed. I'm not sure if changes to the documentation are needed. On one hand the docs are clear that Readme.md and LICENSE.txt are skipped, on the other hand for templates these kinds of files are sometimes essential.

Changelog: Fix: Allow templates for conan new to contain Readme.md and LICENSE.txt files.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vectorsli

Thanks for contributing this fix.
This has already been fixed in 2.0, indeed that didn't make sense.
Could you please add a very short test, or maybe it is enough to add a README file in some of the existing tests, to validate this is working fine?

@memsharded memsharded added this to the 1.51 milestone Jul 26, 2022
@memsharded memsharded merged commit 237b26c into conan-io:develop Jul 26, 2022
@memsharded
Copy link
Member

Merged without a test, but the risk is very low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants