Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate_build over settings #11580

Merged
merged 8 commits into from Jul 12, 2022
Merged

validate_build over settings #11580

merged 8 commits into from Jul 12, 2022

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Jul 6, 2022 •
edited

Changelog: Feature: Introduced a validate_build() method in the recipes to validate if the package can be built according to self.settings and self.options instead of self.info.settings and self.info.options that it is used to validate the binary.
Docs: conan-io/docs#2667

@lasote lasote requested review from czoido and memsharded July 6, 2022 12:04
@lasote lasote added this to the 1.51 milestone Jul 6, 2022
memsharded
memsharded reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many tests are broken, but I fail to see how these changes can cause that breakage

conans/client/graph/graph_binaries.py Outdated Show resolved Hide resolved
conans/client/graph/graph_binaries.py Outdated Show resolved Hide resolved
memsharded
memsharded reviewed Jul 7, 2022
View reviewed changes
conans/client/graph/graph_builder.py Outdated Show resolved Hide resolved
conans/client/graph/graph_manager.py Outdated Show resolved Hide resolved
@memsharded memsharded mentioned this pull request Jul 12, 2022
Closed
@lasote lasote marked this pull request as ready for review July 12, 2022 11:12
@lasote lasote changed the title POC: validate_build over settings validate_build over settings Jul 12, 2022
memsharded
memsharded approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Don't forget to mark it as experimental in the docs

@czoido czoido merged commit fae0b53 into conan-io:develop Jul 12, 2022
@memsharded memsharded mentioned this pull request Jul 14, 2022
Closed
@lasote lasote mentioned this pull request Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
1.51
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasote @czoido @memsharded