Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CMAKE_FIND_ROOT_PATH_MODE_INCLUDE in CMakeToolchain instead of XXX_DIR solution for OSX #9500

Closed
memsharded opened this issue Aug 30, 2021 · 0 comments · Fixed by #9685
Closed

Use CMAKE_FIND_ROOT_PATH_MODE_INCLUDE in CMakeToolchain instead of XXX_DIR solution for OSX #9500

memsharded opened this issue Aug 30, 2021 · 0 comments · Fixed by #9685
Assignees
@lasote
Milestone
1.41

Comments

@memsharded
Copy link
Member

I don't see the new toolchain setting CMAKE_FIND_ROOT_PATH_MODE_INCLUDE, am I missing something? Why this feature in the legacy generators but not the new ones?

find_package() doesn't need CMAKE_FIND_ROOT_PATH_MODE_PACKAGE BOTH in CMakeDeps (see #9202 (comment), but it could be replaced by CMAKE_FIND_ROOT_PATH_MODE_PACKAGE BOTH instead).
find_library(), find_path() and find_file() would also need #9427, CMAKE_FIND_ROOT_PATH_MODE_* BOTH is not sufficient.

Originally posted by @SpaceIm in #9437 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.41
Development

Successfully merging a pull request may close this issue.

Replace XXX_DIR with CMAKE_FIND_ROOT_PATH_MODE_PACKAGE lasote/conan
2 participants
@lasote @memsharded