Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] allow for non-string configuration-specific preprocesor definitions on CMakeToolchain #8632

Closed
1 task done
guiserle opened this issue Mar 11, 2021 · 2 comments · Fixed by #8645
Closed
1 task done
Assignees

Comments

@guiserle
Copy link

Currently CMakeToolchain only allows for string literal definitions due to quotes included on this line of jinja template.
add_definitions(-D{{ it }}="{{ value }}")

This limits the hability to declare integer or other definitions on generate() method. I hope this could be easily workaround by removing the quotes from the jinja template and, instead, adding them on python string variable

@memsharded
Copy link
Member

Hi @guiserle

#8645 should allow it, a bit more tricky than expected, but I think it makes sense, it is a valid request.

@guiserle
Copy link
Author

Looks like a valid solution to me. Thanks for taking the request into account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants