-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] vcvars not called when using clang-cl #6927
Comments
Given the inputs, if the
Reading through the conan/conans/client/build/cmake_flags.py Line 29 in 63b6a28
I'm not an expert in the Windows architecture and the different compilers you can use there, so I'm asking for help now: according to CMake documentation (https://cmake.org/cmake/help/v3.6/generator/MinGW%20Makefiles.html), this generator doesn't look like the best one for this situation...
We can add a patch for this issue, but we really need to understand and maybe rewrite some of our Windows-related helpers. I want to remember here, the pending effort to add a |
Answ
Another workaroundYeah, it does succeed with the Ninja generator.
However, I don't think it's a good choice to make Ninja the default because not everyone have Ninja installed. |
as |
This PR #11492, merged for next 1.53 contains a few changes to better support clang in Windows, mainly for the new There are some other pending issues about the Windows subsystems environment management, we are also trying to improve them in #12178, so if you are using Clang in some subsystem and depend on the environment, you might want to track this PR too. Closing this issue now, but we know that there might still be some gaps, so please try to update to the new integration (this is necessary for 2.0 anyway), and report what might still be failing against this new integration. The best starting point would be the tests in https://github.com/conan-io/conan/blob/develop/conans/test/functional/toolchains/cmake/test_cmake_toolchain_win_clang.py, or using any of the predefined templates |
Environment Details (include every applicable attribute)
Steps to reproduce (Include if Applicable)
Build boost from conan-io/conan-center-index#1453 with line 12 in
test_package/conanfile.py
changed to:Used command with env:
Logs (Executed commands with output) (Include/Attach if Applicable)
Workaround:
As written in https://github.com/conan-io/conan-center-index/pull/1453/files/1ac629706f94f1de0bf7046bed3d258cc8b7112f#diff-173d76810e789cb3c367b7e249928559 , explicitly call
vcvars()
when clang-cl is detected.Additional information
In cmake helper, the vcvar should be added automatically, so the issue may be caused by failure in such code.
The text was updated successfully, but these errors were encountered: