Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Editable libs not removable if deleted #16164

Closed
Sickeroni opened this issue Apr 26, 2024 · 5 comments · Fixed by #16170
Closed

[question] Editable libs not removable if deleted #16164

Sickeroni opened this issue Apr 26, 2024 · 5 comments · Fixed by #16170
Assignees

Comments

@Sickeroni
Copy link

Describe the bug

Error:

If you remove folders that are in editable mode, there is no easy way to remove them from the editable list anymore.

workaround: (not tested)

create new conanfile.py in the specific location.
then it should work again.

Expected behaviour:

using conan editable remove [folder] should remove ALL packages in the editable list from that location.
using conan editable remove [folder]\conanfilefilename.py should remove that specific packages in the editable list.
The second suggestion is only for simplification, even through the location could have more files than the default conanfile.py.
The big difference is to the current behaviour, that the folder can be already deleted.

How to reproduce it

conan new something # creating a new lib, replace with proper command 
conan editable add [folder]
rm -r [folder]
conan editable list
conan editable remove [folder] 
# getting Error
conan editable list
# still see the same list
@memsharded memsharded self-assigned this Apr 26, 2024
@memsharded
Copy link
Member

Hi @Sickeroni

Thanks for your question.

If you remove folders that are in editable mode, there is no easy way to remove them from the editable list anymore.

If you remove the folder containing the editable, you can still remove that editable by reference:

$ conan editable remove -r=mypkg/0.1

Have you tried that?

@Sickeroni
Copy link
Author

Hey
Yeah i just tried it and it works!
therefore already thanks! (also because you were fast with helping)

But now i have a new question.
I would suggest a feature request to have the specific fallback above. (if directory is removed, still interpret it as it would be)
It would much more intuitive and userfriendly.

But I don't think it was never discussed. Can i get some infos about that situation?
(also i qill change the topic to be officially a question)

@Sickeroni Sickeroni changed the title [bug] Editable libs not removable if deleted [question] Editable libs not removable if deleted Apr 29, 2024
@memsharded
Copy link
Member

But now i have a new question.
I would suggest a feature request to have the specific fallback above. (if directory is removed, still interpret it as it would be)
It would much more intuitive and userfriendly.

Sounds reasonable, not sure how difficult it is (I think the way it works now is loading the recipe inside the folder, to obtain the reference), lets have a look.

@memsharded
Copy link
Member

Happens to be trivial, #16170 planned for next 2.3

@memsharded
Copy link
Member

Closed by #16170, will be in 2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants