Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate visible=False for shared dependencies #14736

Closed
memsharded opened this issue Sep 14, 2023 · 1 comment
Closed

Investigate visible=False for shared dependencies #14736

memsharded opened this issue Sep 14, 2023 · 1 comment

Comments

@memsharded
Copy link
Member

memsharded commented Sep 14, 2023

Follow up from #14721. Check the implications of expanding requires with visible=False for re-packaging when dependencies are shared libs

Issue about re-package concept: #13171

@memsharded memsharded added this to the 2.0.12 milestone Sep 14, 2023
@czoido czoido modified the milestones: 2.0.12, 2.0.13, 2.0.14 Sep 26, 2023
@memsharded
Copy link
Member Author

I think at the moment it is fine:

  • If dependencies are direct, they will match because libs=True and headers=True
  • If transitive dependencies are shared libraries too, they will match because run=True

The only problem comes from the scenario:

  • Multiple direct shared dependencies
  • These shared dependencies depend on different versions of the same library, linked as static
  • Users wanted to have a conflict because of these static libraries (conflict will not be raised, and user needs to explicitly override=True to define the same transitive dependency)

Users need to understand these aspects, making a shared dependency visible=False is pretty unusual, and should only happen in the case of re-packaging, so lets wait until #13171 is addressed.

I am closing this issue as not-an-issue, and lets follow up on the re-package ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants