New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakeDeps imported target multiconfig #11691
CMakeDeps imported target multiconfig #11691
Conversation
@@ -41,7 +41,7 @@ def template(self): | |||
endif() | |||
endmacro() | |||
|
|||
function(conan_package_library_targets libraries package_libdir deps out_libraries out_libraries_target config_suffix package_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out_libraries
arg was not used.
|
||
# FIXME: What is the result of this for multi-config? All configs adding themselves to path? | ||
set(CMAKE_MODULE_PATH {{ '${' }}{{ pkg_name }}_BUILD_DIRS{{ config_suffix }}} {{ '${' }}CMAKE_MODULE_PATH}) | ||
set(CMAKE_PREFIX_PATH {{ '${' }}{{ pkg_name }}_BUILD_DIRS{{ config_suffix }}} {{ '${' }}CMAKE_PREFIX_PATH}) | ||
|
||
{%- for comp_variable_name, comp_target_name in components_names %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved below, with the other components code to be easier.
list(APPEND {{ pkg_name }}_LIBRARIES{{ config_suffix }} ${_SYSTEM_LIB}) | ||
endforeach() | ||
|
||
# We need to add our requirements too | ||
set({{ pkg_name }}_LIBRARIES_TARGETS{{ config_suffix }} {{ '"${' }}{{ pkg_name }}_LIBRARIES_TARGETS{{ config_suffix }}{{ '};' }}{{ deps_targets_names }}") | ||
set({{ pkg_name }}_LIBRARIES{{ config_suffix }} {{ '"${' }}{{ pkg_name }}_LIBRARIES{{ config_suffix }}{{ '};' }}{{ deps_targets_names }}") | ||
set({{ pkg_name }}_LIBRARIES{{ config_suffix }} "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @lasote !
I think that you have broken everything here :) The variable was not cleared here before. It seems strange even when looking to several "list(APPEND ...)"
above, which actively push something to this variable.
I didn't understand whole picture though. But the specific problem is: conan=1.51
broke a build of zstd
dependant, where I'm using ${zstd_LIBRARIES}
, which become empty after update. And I'm pretty sure that bug in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking.
Changelog: omit
Docs: omit