Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add relative path support to Git SCM tool #11408

Closed
1 task done
nmasseyKM opened this issue Jun 6, 2022 · 1 comment · Fixed by #11407
Closed
1 task done

[feature] Add relative path support to Git SCM tool #11408

nmasseyKM opened this issue Jun 6, 2022 · 1 comment · Fixed by #11407
Milestone

Comments

@nmasseyKM
Copy link
Contributor

When trying to setup Conan packaging with the target source in a git submodule relative to the recipe, I was receiving
empty commit ids. Upon further investigation, it seems that the current assumption is that the folder path to Git()
will be absolute. A minor adjustment allows relative paths to be used as well: since the git command always chdirs to the
target git folder, we can perform the rev-parse relative to the current directory and receive the expected behavior.

Note that the current default value of "." is a relative path, which suggests that other relative paths should work.

@memsharded
Copy link
Member

Closed by #11407.

Thanks for contributing it! Will be released in next 1.50 (and be part of Conan 2.0 beta, as we merge develop->develop2 continously)

@memsharded memsharded added this to the 1.50 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants