Flip operation When matching a conjunctive and a disjunctive constraint #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to iterate over the disjunctive constraint because the result is correct as long as one of the elements matches, iterating over the conjunctive constraint may result in incorrect matching to a disjunctive constraint
|
phpstan error is unrelated. |
|
AFAICT, the version parser cannot produce complex nesting of multi constraints, because it does not support grouping constraint with parenthesis |
Seldaek
approved these changes
May 24, 2021
|
@Seldaek did you look into deeper nesting before merge? |
|
Nope, I figured this was an improvement already. Deeper nesting as stof mentioned is hard to produce if not by hand. At least the deepest you can go with string constraint parsing is (x OR (y AND z)), not sure if that's deep enough to cause problems. |
|
That's what this bug was about so fine, yeah I suppose more complex ones would be automatically constructed somehow by combining constraints only, and then you're better off using intervals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to iterate over the disjunctive constraint because the result is correct as long as one of the elements matches, iterating over the conjunctive constraint may result in incorrect matching to a disjunctive constraint.
Addresses #126
However will need to look at some more complex scenarios involving multiple levels of nesting of conjunctive and disjunctive multi constraints which I'm not sure about of the top of my head.
Alternatively we'd have to entirely switch to the safer and more correct interval implementation although it may be slower.