Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satis does not mark all abandoned packages as such anymore #686

Open
halloei opened this issue Nov 11, 2021 · 1 comment
Open

Satis does not mark all abandoned packages as such anymore #686

halloei opened this issue Nov 11, 2021 · 1 comment
Labels

Comments

@halloei
Copy link

halloei commented Nov 11, 2021

Describe the bug
I've got multiple packages in my satis.json that are abandoned ( "abandoned": true in their composer.json).
However, Satis does not mark all of them as abandoned on the generated HTML page. In my case only the alphabetically first package is correctly marked as abandoned. All other abandoned packages are shown in blue. The commit which introduced the bug is b432af3.

To Reproduce
Add multiple abandoned packages to the satis.json and build it with the current version from main branch.

Outcome
Not all abandoned packages are marked as abandoned.

Expected behavior
All abandoned packages are marked as abandoned.

@halloei halloei added the bug label Nov 11, 2021
@ghost
Copy link

ghost commented Mar 21, 2022

Hey, I've detected a similar behavior. I have recently marked 7 repositories as abandoned in each project composer.json, but satis only highlighted 2 of them as abandoned after running the build command.

As a workaround, I've set these repositories as abandoned directly in the satis.json file (see https://getcomposer.org/doc/articles/handling-private-packages.md#abandoned-packages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant