Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TastyIgniter Installer #502

Merged
merged 11 commits into from Feb 11, 2022
Merged

Update TastyIgniter Installer #502

merged 11 commits into from Feb 11, 2022

Conversation

sampoyigi
Copy link
Contributor

This PR updates the TastyIgniter installer to use data defined under the extra property when determining the install path.

Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
@sampoyigi
Copy link
Contributor Author

Can't get the phpstan check to pass, what am I missing?

Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
@sampoyigi
Copy link
Contributor Author

@niksamokhvalov could you please have a look?

@niksamokhvalov
Copy link
Member

Error: ] Found 2 errors                                                         
[101](https://github.com/composer/installers/runs/5038318637?check_suite_focus=true#step:7:101)

[102](https://github.com/composer/installers/runs/5038318637?check_suite_focus=true#step:7:102)
Error: Parameter #3 $subject of function preg_replace expects array|string, string|null given.
[103](https://github.com/composer/installers/runs/5038318637?check_suite_focus=true#step:7:103)
Error: Method Composer\Installers\TastyIgniterInstaller::inflectExtensionVars() should return array<string, string> but returns array<string, string|null>.
[104](https://github.com/composer/installers/runs/5038318637?check_suite_focus=true#step:7:104)
Error: Process completed with exit code 1.

May be you will try change phpDocs for inflectExtensionVars()? Returned values and phpDocs isn't compatibility.

Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
@sampoyigi
Copy link
Contributor Author

Thanks, got it passing now, is there anything else I can do here?

@niksamokhvalov niksamokhvalov merged commit e6facf8 into composer:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants