Normalise vendor directory containing hyphen #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendors on Packagist are allowed a hyphen in their name (such as https://packagist.org/packages/grrr-amsterdam/). However, when translating this directory structure into a PHP namespace, it will result in an illegal namespace. This update removes anything from the vendor name that's not alphanumeric or an underscore.
|
Is there no interest at all in merging this? It would help me a great deal, honestly... |
|
@LukeTowers Is there anything you can do to get this reviewed? |
|
@niksamokhvalov @alcohol could one of you review this please? |
|
Woohoo! Thanks a bunch everyone. 👍 |
|
I can see a lot of commits since the latest tag v1.5.0 (including my own 😇). @alcohol It would be great if a new tag could be pushed so Composer would pick up the latest version a little more easily! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors on Packagist are allowed a hyphen in their name (such as
https://packagist.org/packages/grrr-amsterdam/). However, when
translating this directory structure into a PHP namespace, it will
result in an illegal namespace.
This update removes anything from the vendor name that's not
alphanumeric or an underscore.