Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary: Wrong file permissions on targets when Composer use unix proxy file (e. g. Phar file) on WSL #9961

Closed
blankse opened this issue Jun 9, 2021 · 2 comments
Labels
Milestone

Comments

@blankse
Copy link
Contributor

blankse commented Jun 9, 2021

See my last comment here #9958

My composer.json:

{
    "require": {
        "deployer/dist": "^6.8"
    }
}

When I run this command:

php composer.phar install
vendor/bin/dep

I get the following output:

vendor/bin/dep: 14: vendor/bin/dep: /var/www/html/vendor/deployer/dist/dep: Permission denied

And I expected this to happen (works on 2.0.x because composer use symlink here):

Deployer 6.8.0

Usage:
  command [options] [arguments]

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
  -f, --file[=FILE]     Specify Deployer file
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Available commands:
  autocomplete  Install command line autocompletion capabilities
  help          Displays help for a command
  init          Initialize deployer in your project
  list          Lists commands
  run           Run any arbitrary command on hosts
  self-update   Updates deployer.phar to the latest version
  ssh           Connect to host through ssh
 debug
  debug:task    Display the task-tree for a given task
@Seldaek
Copy link
Member

Seldaek commented Jun 9, 2021

The vendor/bin/dep file is made executable, but the binary in the package isn't. Sent a PR there to fix that deployphp/distribution#13

That said, you're right that when using symlinks this was compensed for by Composer making the symlink executable, which makes the original file executable. I've fixed this now so we always make the binary in package executable as well as the proxy files we create.

@Seldaek Seldaek added this to the 2.1 milestone Jun 9, 2021
@Seldaek Seldaek added the Bug label Jun 9, 2021
@Seldaek Seldaek closed this as completed in bf37130 Jun 9, 2021
@blankse
Copy link
Contributor Author

blankse commented Jun 9, 2021

@Seldaek Thanks 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants